-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Prism.js textarea is not correctly rendered on firefox #5171
Comments
It works fine for me on Firefox 84 on Linux. Do you see any errors in the browser console? The sizing is supposed to be done by JavaScript. Can you try if some of the following editors work fine for you? We're not using directly any of these, but the basic idea behind them is same: |
Okay, we rely on ResizeObserver, which is not present in some older browsers: https://caniuse.com/resizeobserver |
Sorry I was caught up playing around with those editors... A bit too late, but for the record:
There are:
All of those work fine
yep, looks like it... |
Thank you for your report, the issue you have reported has just been fixed.
|
@nijel, did you already pushed the fix to the hosted Weblate? |
Not yet. You will notice the fix as it disables highlighting on not supported browsers. |
yep, thanks... I was concerned it didn't work... |
Sorry, but I don't want to spend time on developing support for browsers no longer supported by a vendor. See https://docs.weblate.org/en/latest/contributing/frontend.html for our browser support statement. |
No problem, I'm totally fine with the solution... I thought may be the disabling itself somewhy didn't work out... |
Describe the issue
The textarea is not correctly rendered for me. It displays both the original textarea border as well as the Prism.js's
div
:It's worse with multi-line text:
I already tried
I've tried to run it on a clean profile: the same result.
I'm using firefox-68.4.1 on Linux; I haven't tested with a more recent version yet.
Works fine on Chrome on both Linux and Windows.
Server configuration and status
Weblate installation: weblate.org service
Additional context
Also unlike Chrome the textarea is manually realizable in firefox.
The text was updated successfully, but these errors were encountered: