Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firebase emulators #293

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Add Firebase emulators #293

merged 5 commits into from
Jan 18, 2023

Conversation

th0rgall
Copy link
Contributor

@th0rgall th0rgall commented Jan 17, 2023 •
edited
Loading

  • Test that the local demo environment works
  • Test that the wtmg-dev environment works, hooked up to all emulators
  • Test that the wtmg-dev environment works, hooked up only to the function emulators
  • Test that the live wtmg-dev environment works

Fixes #288

@th0rgall
Ensure .runtimeconfig.json accepts URLs with & without ending slash +…
6fc2c5d 
… ...

when updating statistics in Firestore, perform .set() w/ merge instead of an .update() to prevent an error when the stats docs don't exist yet.
@th0rgall
Add support for the Firebase Emulator Suite, add docs
415eecb
@th0rgall th0rgall temporarily deployed to staging January 17, 2023 10:22 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit d3d5305):

https://wtmg-dev--pr293-firebase-emulators-ayhgag35.web.app

(expires Wed, 25 Jan 2023 13:14:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7773005e481e8bc60fd60a58f2d818cc7378f95b

This was referenced Jan 17, 2023
Closed
Open
@th0rgall th0rgall temporarily deployed to staging January 17, 2023 11:13 — with GitHub Actions Inactive
@th0rgall th0rgall temporarily deployed to staging January 17, 2023 11:14 — with GitHub Actions Inactive
@th0rgall th0rgall temporarily deployed to staging January 17, 2023 15:37 — with GitHub Actions Inactive
@th0rgall
Email verification fixes & improvements
d3d5305 
- listen to onIdTokenChanged instead of onAuthStateChanged, to transition the user through the verification process independently of the prior app state.
- notifies all other tabs (especially: the original account creation tab) of the new verification state via onIdTokenChanged & a forced token refresh (likely this lead to confusion & bugs)
- "unbundle" reloadUserInfo(): avoid .reload() calls when they are not necessary (=> process speedup)
@th0rgall th0rgall temporarily deployed to staging January 18, 2023 13:13 — with GitHub Actions Inactive
@th0rgall th0rgall temporarily deployed to staging January 18, 2023 13:13 — with GitHub Actions Inactive
@th0rgall
Copy link
Contributor Author

With the last commit d3d5305 added, this hopefully also fixes #98.

@th0rgall th0rgall merged commit e6589d6 into master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for all Firebase Emulators
1 participant
@th0rgall