Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/home nav bug (2nd try) #331

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Fix/home nav bug (2nd try) #331

merged 4 commits into from
Jul 26, 2023

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    e4d6ee9 View commit details
    Browse the repository at this point in the history
  2. fix: navigation & scroll issue in Safari by upgrading to Svelte 4 wit…

    …h default local transitions
    
    Caused by global transitions blocking the onDestroy of the old page, which left its nodes in the DOM for 300 ms (probably) after the onMount of the new page triggered. The new page is thus added below the old one (commonly reported issue). This resulted in the onMount ephemerally getting a far too high offsetTop value for the pricing section (because the old page content was still on top), which in turn made the scroll animation scroll to the end of the page instead.
    
    Svelte 4 defaults to local transitions. It's still possible that some local "out" transition blocks the destroy of an old page, but for now, it seems to be fixed, because (now local) transitions on the home page are sufficiently nested.
    
    All transitions were by default"global" before, I couldn't easily check the behavior of all global -> local migration cases. It's possible this fix causes a problem elsewhere. However, keeping the "local" default seems preferrable, since "global" lead to this bug.
    th0rgall committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    57b2c00 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    46e3fde View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. fix: make adapter-static fallback for Firebase Hosting explicit; upgr…

    …ade some deps
    
    According to the docs, it seems to be required now for SPA usage (default is undefined). adapter-static was also out-of-sync with the newest sveltekit. Vite upgrade is unrelated.
    th0rgall committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a42534e View commit details
    Browse the repository at this point in the history