Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing Makefile features #9

Merged
merged 4 commits into from
May 20, 2023

Conversation

msoares94
Copy link
Collaborator

Adding new behaviors and adjusting stop behavior.

Readjusted build and configure behavior as it makes more sense to copy the .env.example only if the project doesn't already have an .env

Updating the Readme.md to reflect the changes, it makes sense to run configure before the build

msoares94 added 2 commits May 19, 2023 12:15
Adding new behaviors and adjusting stop behavior.
    
    Readjusted build and configure behavior as it makes more sense to copy the .env.example only if the project doesn't already have an .env
Updating the Readme.md to reflect the changes, it makes sense to run configure before the build
Copy link
Owner

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments for you to check

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@msoares94 msoares94 requested a review from WendellAdriel May 19, 2023 17:24
Copy link
Owner

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 💪

@WendellAdriel WendellAdriel merged commit 3c79daa into WendellAdriel:main May 20, 2023
@msoares94 msoares94 deleted the fix-makefile branch July 15, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants