Send experience packets to support Bedrock via Geyser #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send experience packets to support Bedrock via Geyser
WesJD
requested changes
Jun 30, 2024
|
final thing to do then is just increment the minor version and we're good to merge ( |
WesJD
approved these changes
Jul 4, 2024
|
Thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
Bedrock does not allow the result slot to be clicked when the player's experience level is 0. This change sends a packet which sets the Bedrock client's level to 20 (number is trivial) on anvil open, and then again back to the actual value when closed. It adds a
.gesyer-compat(boolean)to the builder, which is enabled by default.A second constructor has been added to AnvilGUI for backwards compatibility.In writing this, it occurs to me it may be preferred to have the method be something like
.disableGeyserCompat()instead, to match.preventClose(). Let me know if that's what you'd prefer.Other changes I made in order to test this:
Added a jitpack.yml file which allows AnvilGUI to be compiled on the popular jitpack.io repository