Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases our changes to Horde 0.9.0 (the latest version).
Two additional changes:
This change was incomplete and incorrect in the scenario when a process crashed on the same host. The restarted process might not have been re-added to the registry.
master
- this PR was reverted - 0d8c9aeThat's because we still care about the synchronicity (the PR mentioned in point 1) of the auction process start (that's what OTP's processes rely on), but it's not susceptible to the issue introduced in Add process added to local Register synchronously #2. We also don't care about the scenario that the PR fixed initially because we don't start two processes with the same key.
When this is approved, I will force push to
master
.