Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Transcript File Link on Close Chat #130

Merged
merged 32 commits into from
Apr 28, 2022
Merged

Conversation

AlexanderKanakis
Copy link
Collaborator

@AlexanderKanakis AlexanderKanakis commented Mar 31, 2022

For task WideChat/Rocket.Chat#1121

  • Removes email checks for sending transcript.
  • Receives string in HTML format and creates file for download.

Related PRs: WideChat/Rocket.Chat#1130

@AlexanderKanakis AlexanderKanakis changed the title [EXTEND] Transcript Download Link on Close Chat [Feature] Transcript Download Link on Close Chat Mar 31, 2022
@AlexanderKanakis AlexanderKanakis changed the title [Feature] Transcript Download Link on Close Chat [FEATURE]Transcript Download Link on Close Chat Mar 31, 2022
@AlexanderKanakis AlexanderKanakis changed the title [FEATURE]Transcript Download Link on Close Chat [FEATURE] Transcript Download Link on Close Chat Mar 31, 2022
@AlexanderKanakis AlexanderKanakis changed the title [FEATURE] Transcript Download Link on Close Chat [FEATURE] Transcript File Link on Close Chat Mar 31, 2022
@AlexanderKanakis AlexanderKanakis changed the title [FEATURE] Transcript File Link on Close Chat [IMPROVE] Transcript File Link on Close Chat Mar 31, 2022
Copy link
Collaborator

@Shailesh351 Shailesh351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ear-dev
Copy link

ear-dev commented Apr 14, 2022

@Shailesh351 can you review the last commit please.... (remove options button) Also test in mobile please

@ear-dev
Copy link

ear-dev commented Apr 14, 2022

@AlexanderKanakis Steve is now thinking that downloading in html format might not be the best solution. How hard is it to download as a txt file? Can we do that instead? Thanks...

@Shailesh351
Copy link
Collaborator

@AlexanderKanakis @ear-dev Just for the record, currently Save Chat is not working on mobile. It just opens content in the WebView

Text file is not formatted correctly currently. Alexander is working on it.

Screenshot 2022-04-19 at 8 50 20 PM

@ear-dev
Copy link

ear-dev commented Apr 27, 2022

@AlexanderKanakis this is looking good.... works great! One comment though...... the button should not be available if the Admin has this setting set to false... "Ask Visitor if They Would Like a Transcript After Chat Closed" can you fix please?

image

As it is, the button still appears, but the visitor cannot download the transcript.

src/components/Messages/Message/index.js Outdated Show resolved Hide resolved
Comment on lines 206 to 211
{onChangeDepartment && (
<Menu.Item onClick={onChangeDepartment} icon={ChangeIcon}>{I18n.t('Change department')}</Menu.Item>
)}
{onRemoveUserData && (
<Menu.Item onClick={onRemoveUserData} icon={RemoveIcon}>{I18n.t('Forget/Remove my data')}</Menu.Item>
)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderKanakis @ear-dev FYI This removes the Forget/Remove my data feature. Which we are not using at the moment. Just keep a note for the future.

src/components/Messages/Message/index.js Outdated Show resolved Hide resolved
src/components/Messages/Message/index.js Outdated Show resolved Hide resolved
@Shailesh351
Copy link
Collaborator

@AlexanderKanakis I have pushed code to incorporate above changes.

@Shailesh351
Copy link
Collaborator

@AlexanderKanakis @ear-dev I just readded the options menu. And only removed the Finish Chat option from it. All the other options are configurable. So when all are disabled it won't show the options menu. It's also better to do it this way because we will get fewer conflicts while upstream catchup.

Please also verify at your end. Thanks!

98500ac

@ear-dev
Copy link

ear-dev commented Apr 28, 2022

@Shailesh351 this is good to go? I think we should enable the isMobile switch in a separate PR....

@Shailesh351
Copy link
Collaborator

@ear-dev Yupp, Good to merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants