-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Transcript File Link on Close Chat #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@Shailesh351 can you review the last commit please.... (remove options button) Also test in mobile please |
@AlexanderKanakis Steve is now thinking that downloading in html format might not be the best solution. How hard is it to download as a txt file? Can we do that instead? Thanks... |
@AlexanderKanakis @ear-dev Just for the record, currently Text file is not formatted correctly currently. Alexander is working on it. |
@AlexanderKanakis this is looking good.... works great! One comment though...... the button should not be available if the Admin has this setting set to false... "Ask Visitor if They Would Like a Transcript After Chat Closed" can you fix please? As it is, the button still appears, but the visitor cannot download the transcript. |
src/routes/Chat/component.js
Outdated
{onChangeDepartment && ( | ||
<Menu.Item onClick={onChangeDepartment} icon={ChangeIcon}>{I18n.t('Change department')}</Menu.Item> | ||
)} | ||
{onRemoveUserData && ( | ||
<Menu.Item onClick={onRemoveUserData} icon={RemoveIcon}>{I18n.t('Forget/Remove my data')}</Menu.Item> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderKanakis @ear-dev FYI This removes the Forget/Remove my data
feature. Which we are not using at the moment. Just keep a note for the future.
@AlexanderKanakis I have pushed code to incorporate above changes. |
@AlexanderKanakis @ear-dev I just readded the options menu. And only removed the Please also verify at your end. Thanks! |
@Shailesh351 this is good to go? I think we should enable the isMobile switch in a separate PR.... |
@ear-dev Yupp, Good to merge this PR |
For task WideChat/Rocket.Chat#1121
Related PRs: WideChat/Rocket.Chat#1130