Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] setGuestPhone to support empty/null/undefined #143

Merged
merged 2 commits into from
May 16, 2022
Merged

[FIX] setGuestPhone to support empty/null/undefined #143

merged 2 commits into from
May 16, 2022

Conversation

Shailesh351
Copy link
Collaborator

@Shailesh351 Shailesh351 commented May 13, 2022 •
edited
Loading

Part of WideChat/Rocket.Chat#1139

To Test In the Livechat Widget Integration Script

  • Set visitor phone: this.setGuestPhone(<phoneNumber>)
  • To unset visitor phone pass ''/null/undefined or just blank : this.setGuestPhone()/this.setGuestPhone('')

@Shailesh351 Shailesh351 mentioned this pull request May 13, 2022
Closed
ear-dev
ear-dev approved these changes May 16, 2022
View reviewed changes
Copy link

@ear-dev ear-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shailesh351

@ear-dev ear-dev merged commit 2839975 into develop May 16, 2022
@ear-dev ear-dev mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ear-dev ear-dev ear-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shailesh351 @ear-dev