-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Livechat] Refactor setGuestPhone to remove entry upon empty string #1139
Comments
Design: do not create an unset function.... factor the current function remove the telephoneNumber entry in mongodb if we send it an empty string.
|
Updated PRs: Created |
@ear-dev As discussed in the meeting yesterday, because @AlexanderKanakis is currently away due to medical treatment I have created below PRs to fix this issue. Thanks! Rocket.Chat: #1178
|
Thanks @Shailesh351 I will test as well.... |
We added setGuestPhone() to livechat so that we could set that with our test widget. It turns out that the livechat data is persistent and stored on the server side, so we need a new method
unsetGuestPhone()
in order to have the ability to clear the number when we don't want to use it.The text was updated successfully, but these errors were encountered: