Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Character handling is not correct in the RC Admin UI view, or in Salesforce #1321

Closed
ear-dev opened this issue Oct 11, 2022 · 4 comments · Fixed by #1326
Closed

[BUG] Character handling is not correct in the RC Admin UI view, or in Salesforce #1321

ear-dev opened this issue Oct 11, 2022 · 4 comments · Fixed by #1326
Assignees
@Shailesh351

Comments

@ear-dev
Copy link

ear-dev commented Oct 11, 2022 •
edited
Loading

We recently fixed special character handling in the message parser as it appears in the widget. Currently that part looks good. But if you look at the RC Admin UI and view a conversation, the special characters are mangled. It also shows up that way in Salesforce, which we definitely need to fix.

Our recent fix: #1308

View in the Widget:

image

View in RC UI:

image

View in Salesforce:

image
@AlexanderKanakis AlexanderKanakis mentioned this issue Oct 18, 2022
Merged
@AlexanderKanakis AlexanderKanakis linked a pull request Oct 18, 2022 that will close this issue
[FIX] Unescape LC Messages #1326
Merged
@AlexanderKanakis
Copy link
Collaborator

image
SF view

@ear-dev
Copy link
Author

ear-dev commented Oct 18, 2022

@AlexanderKanakis please revert the livechat changes we made in our initial fix for this issue and attach the PR to this story. Thanks.

@ear-dev
Copy link
Author

ear-dev commented Oct 20, 2022

@AlexanderKanakis please revert the livechat changes we made in our initial fix for this issue and attach the PR to this story. Thanks.

@AlexanderKanakis did you also do this and test?

@AlexanderKanakis
Copy link
Collaborator

WideChat/Rocket.Chat.Livechat#156. Tested.

@ear-dev ear-dev closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shailesh351 Shailesh351

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Unescape LC Messages WideChat/Rocket.Chat
3 participants
@Shailesh351 @AlexanderKanakis @ear-dev