[NEW] Extract message service SID from incoming message and save to room #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ear-dev
reviewed
Sep 19, 2023
| if (message.customFields && message.customFields.messagingServiceSid) { | ||
| const { messagingServiceSid } = message.customFields; | ||
| extraData = Object.assign({}, extraData, { messagingServiceSid }); | ||
| if (room.sms.messaging_service_sid) { |
There was a problem hiding this comment.
Does this add messaging_service_sid to all of our bot responses to twilio, and not just the responses that include contentSid? Is that the way we want to do it? Are we sure that won't cause any confusion on the twilio side? Or should we just be adding this when there is also the customFields with contentSid?
ear-dev
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1397
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments