Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global loading indicator #71

Open
aonic opened this issue Feb 16, 2014 · 1 comment
Open

Global loading indicator #71

aonic opened this issue Feb 16, 2014 · 1 comment

Comments

@aonic
Copy link
Collaborator

aonic commented Feb 16, 2014

At least on my development machines, there is a noticeable lag when doing actions that require loading data from Magento, such login/register, add to basket, load basket.

Can we implement something at the angular Http service level to add some kind of loading status/indicator to let the user know something is going on?

@Wildhoney
Copy link
Owner

I'm not sure if we should make this part of the Http service, or to implement it locally to each element – I've implemented it locally on the login section. If we implement it in the Http service then the loading icon will have to go somewhere general, and as our app supports parallel actions, how would we handle multiple loading indicators? For me I'd expect the loading status to be on the button I clicked. For the loading of the basket and other sections (such as the filters), then I think those should be localised as well. I'll have a think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants