Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure annotations marks test logs as failures #27

Closed
capnspacehook opened this issue Sep 22, 2023 · 2 comments · Fixed by #28
Closed

test failure annotations marks test logs as failures #27

capnspacehook opened this issue Sep 22, 2023 · 2 comments · Fixed by #28

Comments

@capnspacehook
Copy link

I think annotating test failures is a really good idea, however I noticed that calls to testing.(T).Log and friends match the test failure annotation regex.

Here's an example of this happening (at the very bottom): https://github.com/capnspacehook/egress-eddie/pull/61/files

@WillAbides
Copy link
Owner

Thank you for reporting this. I'll work on fixing this today.

@WillAbides
Copy link
Owner

v1.12.0 reverts to the old behavior unless you set annotate-test-logs: true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants