Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty AppLogo as default value #150

Open
floh96 opened this issue Feb 6, 2021 · 6 comments
Open

empty AppLogo as default value #150

floh96 opened this issue Feb 6, 2021 · 6 comments
Assignees

Comments

@floh96
Copy link
Contributor

floh96 commented Feb 6, 2021

Summary of the new feature/enhancement

would it be possible that you change the default value of AppLogo to an empty/no logo?
Is it possible to create a notification without AppLogo at the moment?

@Windos
Copy link
Owner

Windos commented Feb 22, 2021

You can get a toast without an AppLogo, at the moment though only by proving a path to a non-existent file (unless I'm forgetting something deep in my own code haha!)

New-BurntToastNotification -AppLogo C:\fake.png

You will get a warning that this file doesn't exist though.

The reason I never included this as an option was because in older versions of Windows 10 not having an AppLogo was ugly, but that changed in 20H2.

I think what we should do here is make it so that this works:

New-BurntToastNotification -AppLogo $null

And also make it so that you can remove the default AppLogo path in the config file in order to get no AppLogo (I think at the moment removing that will error, but haven't tested 🤔)

@Windos
Copy link
Owner

Windos commented Feb 22, 2021

Confirmed cannot remove default logo path from config.json, could change it to fake file but all toasts will generate warning.

Will get a getter options in the next update, @floh96, thanks for the suggestion!

@A9G-Data-Droid
Copy link

Or just a simple: -NoLogo option

@Windos
Copy link
Owner

Windos commented Apr 25, 2021

Don't worry, v1 is on the way and there'll be a good option for this included ;)

@anthonyjvoss
Copy link

@Windos - is this issue still up for grabs or has this already been implemented for the upcoming v1 release?

@Windos
Copy link
Owner

Windos commented Oct 12, 2021

Hey @anthonyjvoss, yes consider this up for grabs.

v1 is still a ways out, and even then I'm thinking I'll need to support 0.x with updates even after it's out given how big of a change it'll be. That and anything fixed now will direct what "feature parity" is for v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants