Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyablePersistentTraits has been removed from v8 since March #1207

Closed
LqdBcnAtWork opened this issue Jun 24, 2024 · 1 comment
Closed

CopyablePersistentTraits has been removed from v8 since March #1207

LqdBcnAtWork opened this issue Jun 24, 2024 · 1 comment

Comments

@LqdBcnAtWork
Copy link
Contributor

Hello, I'm trying to build better-sqlite3@11.0.0 for electron.js@31.0.2 using electron-builder@24.13.3.

However it's throwing an error saying that 'CopyablePersistentTraits': is not a member of 'v8'.

Downgrading electron to 30.1.2 removed this issue.

I'm not sure what will have to be done, but this is the commit in github that removed the struct from v8:
v8/v8@4683daa

It used to call out that v8::Global was to be used instead of the deprecated struct.

I'd offer to help more, but my ability with C++ is restricted to being able to sort of to read it.

Also, this is the first time node-gyp actually worked for me. It's a kind of novel experience.

@LqdBcnAtWork
Copy link
Contributor Author

Just found #1200 , this will fix itself with time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant