Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With the hybrid option enabled, a backslash at the end of a document breaks the conversion of the last paragraph #502

Closed
Witiko opened this issue Sep 20, 2024 · 0 comments · Fixed by #503
Closed

With the hybrid option enabled, a backslash at the end of a document breaks the conversion of the last paragraph #502

Witiko opened this issue Sep 20, 2024 · 0 comments · Fixed by #503
Assignees
@lostenderman
Labels
bug conversion output Related to the output format of the Markdown-to-TeX conversion lua Related to the Lua interface and implementation
Milestone
3.8.1

Comments

@Witiko
Copy link
Owner

Witiko commented Sep 20, 2024 •
edited
Loading

With the hybrid option disabled, a backslash (\) at the end of a document produces the command \markdownRendererBackslash, as expected:

$ docker run --rm -i witiko/markdown markdown-cli hybrid=false <<< 'foo \'$'\n''bar \'

\markdownRendererDocumentBegin
foo\markdownRendererHardLineBreak
{}bar \markdownRendererBackslash{}\markdownRendererDocumentEnd
$ docker run --rm -i witiko/markdown markdown-cli hybrid=false <<< 'foo'$'\n\n''bar \'

\markdownRendererDocumentBegin
foo\markdownRendererParagraphSeparator
{}bar \markdownRendererBackslash{}\markdownRendererDocumentEnd

With the hybrid option enabled, a backslash (\) at the end of a document should produce a literal backslash:

\markdownRendererDocumentBegin
foo\markdownRendererHardLineBreak
{}bar \\markdownRendererDocumentEnd
\markdownRendererDocumentBegin
foo\markdownRendererParagraphSeparator
{}bar \\markdownRendererDocumentEnd

However, it produces the following output instead:

$ docker run --rm -i witiko/markdown markdown-cli hybrid=true  <<< 'foo \'$'\n''bar \'

\markdownRendererDocumentBegin
nil\markdownRendererDocumentEnd
$ docker run --rm -i witiko/markdown markdown-cli hybrid=true  <<< 'foo'$'\n\n''bar \'

\markdownRendererDocumentBegin
foo\markdownRendererDocumentEnd

As you can see, with the hybrid option enabled, a backslash at the end of a document breaks the conversion of the whole last paragraph, potentially replacing the paragraph with the text nil.
@Witiko Witiko added bug lua Related to the Lua interface and implementation conversion output Related to the output format of the Markdown-to-TeX conversion labels Sep 20, 2024
@Witiko Witiko added this to the 3.7.1 milestone Sep 20, 2024
@Witiko Witiko changed the title With the hybrid option enabled, a backslash at the end of a document breaks the conversion With the hybrid option enabled, a backslash at the end of a document breaks the conversion of the last paragraph Sep 20, 2024
Witiko added a commit that referenced this issue Sep 20, 2024
@Witiko
Add regression tests for #502
ac96662
@Witiko Witiko mentioned this issue Sep 20, 2024
Merged
3 tasks
Witiko added a commit that referenced this issue Sep 20, 2024
@Witiko
Add regression tests for #502
38771a9
Witiko added a commit that referenced this issue Sep 20, 2024
@Witiko
Add regression tests for #502
2e70626
@Witiko Witiko modified the milestones: 3.7.1, 3.8.0 Sep 30, 2024
@Witiko Witiko modified the milestones: 3.8.0, 3.8.1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostenderman lostenderman

Labels
bug conversion output Related to the output format of the Markdown-to-TeX conversion lua Related to the Lua interface and implementation
Projects
None yet
Milestone
3.8.1
Development

Successfully merging a pull request may close this issue.

Fix backslashes at the ends of hybrid documents Witiko/markdown
2 participants
@Witiko @lostenderman