Fails to install using node v8.4.0 and npm 5.5.1 on mac

[ivanistheone]

npm ERR! Failed at the canvas@1.1.6 install script.

ivan@probook ~/P/F/FlashConvert> npm install jeff 2>&1 | grep error
../../nan/nan.h:342:68: error: too many arguments to function call, expected at most 2, have 4
../../nan/nan.h:424:3: error: redefinition of 'NanNew'
../../nan/nan.h:442:36: error: redefinition of 'NanNew'
../../nan/nan.h:454:36: error: redefinition of 'NanNew'
../../nan/nan.h:623:19: error: no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
../../nan/nan.h:622:36: error: redefinition of 'NanNew'
../../nan/nan.h:637:27: error: redefinition of '_NanEscapeScopeHelper'
../../nan/nan.h:653:12: error: no matching function for call to '_NanEscapeScopeHelper'
../../nan/nan.h:658:12: error: no matching function for call to '_NanEscapeScopeHelper'
../../nan/nan.h:663:12: error: no matching function for call to '_NanEscapeScopeHelper'
../../nan/nan.h:668:12: error: no matching function for call to '_NanEscapeScopeHelper'
../../nan/nan.h:701:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
../../nan/nan.h:707:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
../../nan/nan.h:712:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
../../nan/nan.h:718:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
../../nan/nan.h:797:15: error: no type named 'WeakCallbackData' in namespace 'v8'
../../nan/nan.h:797:31: error: expected ')'
../../nan/nan.h:798:42: error: use of undeclared identifier 'data'
../../nan/nan.h:889:13: error: no member named 'smalloc' in namespace 'node'
fatal error: too many errors emitted, stopping now [-ferror-limit=]
13 warnings and 20 errors generated.
gyp ERR! build error

any suggestions how to workaround?

Would love to try this on some swf files.

[ronkorving]

Hi @ivanistheone,

I think the workaround would be to downgrade Node.js.

The solution would be to upgrade the dependency that's failing (which seems to be canvas) to a newer version that has a NAN version compatible with Node.js 8. Going by the canvas history file it seems like some updates wrt. NAN have happened. Hopefully enough to take it to Node 8.

I'm not a fan of blindly updating dependencies, especially given the fact that Jeff has no test suite. Does anyone know of a reason though that we could not upgrade canvas to the latest version? Perhaps @tbrebant or @bchevalier?

[ronkorving]

Update:

After installing pango (a documented requirement of canvas), I've been able to bump canvas to its latest stable version 1.6.9 on Node 8 and on Node 9. The entire Jeff project compiles. Now whether it runs correctly or not, I can't tell (lack of tests).