Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Deprecate Utilities.StartProtocol() #64

Closed
osulli opened this issue Jan 28, 2021 · 0 comments · Fixed by #99
Closed

Deprecate Utilities.StartProtocol() #64

osulli opened this issue Jan 28, 2021 · 0 comments · Fixed by #99
Labels
enhancement New feature or request

Comments

@osulli
Copy link
Collaborator

osulli commented Jan 28, 2021

.. and Utilities.FinishProtocol()

Why

  • Adds Spam to CET
  • No longer needed with UI and good feedback from the input
  • 'Help Text' duplicated in protocols.lua

Further Details

Available solutions:

  • Have the description inside the Function and have ImGUI read it
  • Pass the description from protocols.lua into the function and have a much smaller "Starting: %s" than what we have in utility.lua
@osulli osulli added the enhancement New feature or request label Jan 28, 2021
@osulli osulli mentioned this issue Feb 23, 2021
Merged
@Nats-ji Nats-ji linked a pull request Feb 27, 2021 that will close this issue
Removed StartProtocol() #99
Merged
@Nats-ji Nats-ji closed this as completed Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed StartProtocol() Nats-ji/BraindanceProtocol
2 participants
@Nats-ji @osulli