Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read the user's preferred locale from the user agent #23

Open
ann-kilzer opened this issue Apr 24, 2024 · 2 comments · May be fixed by #59
Open

Read the user's preferred locale from the user agent #23

ann-kilzer opened this issue Apr 24, 2024 · 2 comments · May be fixed by #59
Assignees
@ann-kilzer
Labels
good first issue Good for newcomers help wanted Extra attention is needed localization

Comments

@ann-kilzer
Copy link
Collaborator

I put in i18n-next quickly, but there are some things we can do to improve the experience.

First one: Read the user's preferred locale from the user agent

This might be useful
https://github.com/i18next/i18next-browser-languageDetector
@ann-kilzer ann-kilzer added localization good first issue Good for newcomers help wanted Extra attention is needed labels Apr 24, 2024
@sirbully sirbully self-assigned this Jun 15, 2024
@ann-kilzer
Copy link
Collaborator Author

@sirbully Okay to unassign this one until #49 is done? I might do some pair programming with Aidan

@sirbully
Copy link
Contributor

@ann-kilzer Yes! Sorry I'm so slow 😭🙇‍♀️

@sirbully sirbully removed their assignment Jul 16, 2024
@ann-kilzer ann-kilzer self-assigned this Jul 25, 2024
@AidanFournier AidanFournier linked a pull request Jul 25, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ann-kilzer ann-kilzer

Labels
good first issue Good for newcomers help wanted Extra attention is needed localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read locale from http headers AidanFournier/home
2 participants
@ann-kilzer @sirbully