Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpHub] Content review: Video shortcode #469

Open
Tracked by #834
estelaris opened this issue Sep 26, 2022 · 12 comments
Open
Tracked by #834

[HelpHub] Content review: Video shortcode #469

estelaris opened this issue Sep 26, 2022 · 12 comments
Assignees
Labels
Content Review self-assigned [Status] Review Issue in review user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@estelaris
Copy link
Member

Issue Description

Still contains links to Codex

URL of the Page with the Issue

Video shortcode

Section of Page with the issue

Related

Why is this a problem?

Are links still valid? Are there plans to bring the other shortcode articles into DevHub?

Suggested Fix

If needed, transfer the other shortcode articles into DevHub and move this article to DevHub as marked in #388

@estelaris estelaris added developer documentation (DevHub) Improvements or additions to developer documentation Content Review advanced administration Issues for Advanced administration Handbook labels Sep 26, 2022
@github-actions
Copy link

Heads up @lucprincen @javiercasares - the "advanced administration" label was applied to this issue.

@estelaris estelaris added user documentation (HelpHub) Improvements or additions to end-user documentation and removed developer documentation (DevHub) Improvements or additions to developer documentation advanced administration Issues for Advanced administration Handbook labels Sep 28, 2022
@github-actions
Copy link

Heads up @femkreations @atachibana - the "user documentation" label was applied to this issue.

@estelaris estelaris changed the title [DevHub] Content review: Video shortcode [HelpHub] Content review: Video shortcode Sep 28, 2022
@estelaris
Copy link
Member Author

I found other shortcode articles and these can be used in the code block so they can remain in en-user documentation.

@carmoreira
Copy link

Hi! I'll try to tackle this one as my first issue 🙌

@marconmartins
Copy link

I will check this.

@zzap zzap assigned marconmartins and unassigned carmoreira Jun 8, 2023
@marconmartins
Copy link

Revised the codex links of the Video Shortcode page and below are the revised versions of the linked shortcode pages.

Caption Shortcode
Updated the shortcode parameters, a couple were missing.
https://docs.google.com/document/d/1ELKXlJ3-72N7HQstClApw3gFivu60SuutRTVIi7alJE/edit?usp=sharing

Embed Shortcode
Updated some links from codex to the new documentation.
https://docs.google.com/document/d/1812oZyG7BAabYxXldk4oGyeKeQNwP6iWPar5jWr9nm4/edit?usp=sharing

Gallery Shortcode
Updated some links from codex that have a new version and updated the options section with the ids arguments.
https://docs.google.com/document/d/1I7DmNA8BnUQM2AViP0SYmjkTA0S5fbnpPQiVyQ7SJrE/edit?usp=sharing

Playlist Shortcode
Updated some links from codex that have a new version.
https://docs.google.com/document/d/12KYTDMxEvQpQXEpwNkXehh4_vXvSLP7DoeNtUivn2gk/edit?usp=sharing

@zzap zzap moved this from 📋 Backlog to 👀 In review in Advanced administration handbook Jun 13, 2023
@zzap zzap moved this to Ready for review in End-user documentation Jun 13, 2023
@pekkakortelainen
Copy link

I'll review this as discussed in Slack :)

@pekkakortelainen
Copy link

One question, otherwise everything LGTM!

Should the Options section of the Gallery Shortcode page have links to Codex page "How to Pass Tag Parameters", with respective subsection links? (integer, string etc.)

Other pages follow that kind of styling.

@atachibana
Copy link
Collaborator

@pekkakortelainen
Thank you for the review.

If possible, I think that the Gallery Shortcode options should have the same information as other Shortcodes. However, the link should be to the PHP manual (e.g. https://www.php.net/manual/en/language.types.php), not the Codex, because it is deprecated.

@github-actions
Copy link

Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue.

@flexseth
Copy link
Collaborator

/assign

Copy link

Hey @flexseth, thanks for your interest in this issue! 🍪🍪🍪
If you have any questions, do not hesitate to ask them in our #docs Slack channel.
Enjoy and happy contributing ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Review self-assigned [Status] Review Issue in review user documentation (HelpHub) Improvements or additions to end-user documentation
Projects
Status: Ready for review
Development

No branches or pull requests

10 participants