-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HelpHub] Content review: Video shortcode #469
Comments
Heads up @lucprincen @javiercasares - the "advanced administration" label was applied to this issue. |
Heads up @femkreations @atachibana - the "user documentation" label was applied to this issue. |
I found other shortcode articles and these can be used in the code block so they can remain in en-user documentation. |
Hi! I'll try to tackle this one as my first issue 🙌 |
I will check this. |
Revised the codex links of the Video Shortcode page and below are the revised versions of the linked shortcode pages. Caption Shortcode Embed Shortcode Gallery Shortcode Playlist Shortcode |
I'll review this as discussed in Slack :) |
One question, otherwise everything LGTM! Should the Options section of the Gallery Shortcode page have links to Codex page "How to Pass Tag Parameters", with respective subsection links? (integer, string etc.) Other pages follow that kind of styling. |
@pekkakortelainen If possible, I think that the Gallery Shortcode options should have the same information as other Shortcodes. However, the link should be to the PHP manual (e.g. https://www.php.net/manual/en/language.types.php), not the Codex, because it is deprecated. |
Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue. |
/assign |
Issue Description
Still contains links to Codex
URL of the Page with the Issue
Video shortcode
Section of Page with the issue
Related
Why is this a problem?
Are links still valid? Are there plans to bring the other shortcode articles into DevHub?
Suggested Fix
If needed, transfer the other shortcode articles into DevHub and move this article to DevHub as marked in #388
The text was updated successfully, but these errors were encountered: