Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpHub] Typography Settings overview #716

Open
11 tasks
femkreations opened this issue Mar 10, 2023 · 10 comments
Open
11 tasks

[HelpHub] Typography Settings overview #716

femkreations opened this issue Mar 10, 2023 · 10 comments
Assignees
Labels
6.2 Changes in 6.2 release 6.3 Changes in 6.3 release block editor Gutenberg related issues good first issue Good for newcomers medium priority self-assigned [Status] Review Issue in review tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@femkreations
Copy link
Collaborator

femkreations commented Mar 10, 2023

Article: https://wordpress.org/documentation/article/typography-settings-overview/

Update for 6.3

  • Add text columns (column count) to typography block supports. 33587

Update for 6.2

  • FontSizePicker: Update hint text to match the design. 44966
  • Update design of FontSizePicker when withSlider is set 44598
  • NumberControl: Add custom spin buttons 45333
  • ToolsPanel: Add subheadings and reset text to tools panel menu 44260

General

  • Make sure all screenshots are relevant to the latest version
  • Make sure videos, if any, are up to date
  • Add ALT tags for the images
  • Make sure the headings are in sentence case
  • Convert all reusable blocks to a ‘regular block’.
  • Update the changelog at the end of the article
@femkreations femkreations added user documentation (HelpHub) Improvements or additions to end-user documentation block editor Gutenberg related issues medium priority 6.2 Changes in 6.2 release labels Mar 10, 2023
@zzap
Copy link
Member

zzap commented Mar 10, 2023

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@github-actions
Copy link

Heads up @femkreations @atachibana - the "user documentation" label was applied to this issue.

@github-actions
Copy link

Heads up @zzap @femkreations - the "block editor" label was applied to this issue.

@carolinan carolinan self-assigned this Apr 3, 2023
@carolinan
Copy link
Collaborator

This update has been published:

  • Updated screenshot to show the slider used to select the custom font size
  • Updated screenshot that showed the old cog settings icon
  • Updated the list of blocks that support typography controls

@carolinan carolinan removed their assignment May 26, 2023
@femkreations femkreations added good first issue Good for newcomers 6.3 Changes in 6.3 release labels Jul 14, 2023
@Leonardus-Nugraha Leonardus-Nugraha added the tracking issue Use to track a series of related issues. label Jul 25, 2023
@zzap zzap added the [Status] To do Issue marked as Todo label Sep 14, 2023
@jukka-is
Copy link

/assign

@github-actions
Copy link

Hey @jukka-is, thanks for your interest in this issue! 🍪🍪🍪
If you have any questions, do not hesitate to ask them in our #docs Slack channel.
Enjoy and happy contributing ❤️

@jukka-is
Copy link

Added a new screen recording for Line height section of the article as NumberControl ui-element has changed since 6.2. 45333

typography-settings-line-height.mov

@Leonardus-Nugraha Leonardus-Nugraha added [Status] Review Issue in review and removed [Status] To do Issue marked as Todo labels Oct 10, 2023
@github-actions
Copy link

Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue.

@anandau
Copy link
Collaborator

anandau commented Jan 23, 2024

Hi @jukka-is

Thanks for sharing the recording of the Line height section. The comma (,) is used as a decimal separator in your video. This might be confusing for many users. For documentation, it is recommended to take screenshots of the WordPress setup with the default language. Can you provide a revised screen recording?

Also, in the current video, there is not much space below the line height field. Because of this, if my mouse is on the video and video player controls are visible, it overlaps the line height field in the video (see screenshot). Including some more space below the line height control can make it better.

Screenshot 2024-01-23 at 7 12 20 PM

@sagargurnani99
Copy link
Collaborator

@anandau This issue seems to be abandoned and because you are already involved in it as a reviewer. Would you mind taking it over and completing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.2 Changes in 6.2 release 6.3 Changes in 6.3 release block editor Gutenberg related issues good first issue Good for newcomers medium priority self-assigned [Status] Review Issue in review tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation
Projects
Status: Needs 1st Review
Development

No branches or pull requests

7 participants