-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Playground Block on Learn WordPress. #2352
Comments
Thanks @brandonpayton @alexstine I can confirm that this version of the playground block is active on the Learn site, and we can test this on the test page. Do you have some time in the coming weeks to test the issues that @brandonpayton has linked in the comment above? |
@brandonpayton Two more small issues.
This has come a long way, thanks for the hard work on it. |
@alexstine, thanks for your review and continued feedback. I'm glad this is trending in the right direction! The two new issues are logged, and I'm working on them next: |
Thanks @brandonpayton |
Thanks @brandonpayton @alexstine I can confirm that this new version has been deployed to learn.wordpress.org, which you can test on the test page. |
Hi @jonathanbossenger, a new version of the Playground block (interactive-code-block) has been released (v0.2.13), and it (along with v0.2.12) contains updates to address the following issues:
These issues are left open until we can confirm they are indeed fixed. Today, the remaining a11y issue is: I'm not sure if it is a blocker, but I haven't been able to figure out a good fix for it yet. |
Thanks @brandonpayton @alexstine I can confirm that the new version of the playground block has been deployed to learn.wordpress.org. It would be greatly appreciated if you have time to test it. The test page is still at the following URL: https://learn.wordpress.org/test/wordpress-playground-block-plugin-test-page/ |
Hi @jonathanbossenger, version v0.2.14 is now released which additionally contains a fix for |
Thank you @brandonpayton. I'm going to raise this to the training team in our weekly meeting this week, to see if we can get some more help with testing, so we can confirm that everything works as expected. |
@brandonpayton I've created a consolidated list of open issues related to the playground block in the main description of this issue. Could you verify that a) I've gathered all the relevant issues into that list and b) only the open issues need testing? I am reaching out to folks to help with testing, so I want to make it easier for them to see what needs testing. |
I'll go through this next week. |
Thanks @joedolson |
That list looks good, except that we could add: I'm not sure if it is a blocker. |
@jonathanbossenger We have released v0.2.15 of the Playground block (interactive-code-block) that contains a fix for WordPress/playground-tools#343. That issue can be added to the list above. Thank you! |
Done, thanks @brandonpayton. @joedolson it might take a day or so for the updated block to be deployed to Learn.WordPress.org for you to be able to test WordPress/playground-tools#343 |
This is still on my radar; but I had a client project abruptly transition from a Sept. 9 launch date to an Aug 23 launch date for emergent reasons, and it's pretty much trashed my week. |
Thank you, @joedolson. Good luck with everything! |
Adding a new comment so I can check these off as I confirm them.
|
Almost everything is done here, except that I think there is a significant improvement that could be made on WordPress/playground-tools#290. I'd recommend completing that recommendation, but then I think this is good. |
Thanks for your help, @joedolson! @jonathanbossenger the remaining work is on my radar, and I plan to look at it next, in the next couple of days. cc @adamziel |
@jonathanbossenger, we've released v0.2.16 of the interactive-code-block plugin with some changes in response to @joedolson's comments here. The changes add:
|
Just let me know when that's available for testing and I'll check it out! |
@jonathanbossenger, do you know if v0.2.16 is available for testing on the Learn site yet? |
Folks, I am so sorry, I missed this message, and it fell off my radar. The plugin is indeed running the latest version of the playground block. @joedolson, if you have some time, can you test the last items discussed here? It'll be great to be able to close this out before the year wraps up. |
Once #2264 is merged and deployed, let's create a test/example lesson in preview mode, and test the playground block.
Test page
You can test the playground block in both default and code view mode at the following URL
Issues list
The text was updated successfully, but these errors were encountered: