Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

How to process xpacket in toVdom #117

Closed
SantosGuillamot opened this issue Dec 12, 2022 · 1 comment
Closed

How to process xpacket in toVdom #117

SantosGuillamot opened this issue Dec 12, 2022 · 1 comment

Comments

@SantosGuillamot
Copy link
Contributor

We've found a couple of sites that have xpacket sections: talsunovads.lv and hlz.de.

Checking the nodeType, it seems they are considered nodeType 7. As we are not handling that use case, it returns an error: TypeError: Cannot read properties of undefined (reading 'length').

We have to decide what to do with these nodes. Should we do the same as with CDATA nodes? It seems a similar case, as they are included inside the SVGs.

@DAreRodz
Copy link
Collaborator

Should we do the same as with CDATA nodes? It seems a similar case, as they are included inside the SVGs.

It's a similar case indeed, but I think we should remove them in this case like we are doing with comments.

To be honest, I don't fully understand how browsers handle Processing Instruction nodes once they're instantiated. And the only thing I've found regarding xpacket instructions is that they work as opening and closing tags of XMP metadata sections in media files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants