-
Notifications
You must be signed in to change notification settings - Fork 11
🎨 Add basic router and wp link directive #83
🎨 Add basic router and wp link directive #83
Conversation
Not sure if I'm doing something wrong but it seems this PR breaks the EDIT: Oh, it is this code to test it out and it should be fixed once we add the wp-link attribute in PHP in #81? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it, but the code looks great. 💯
Yes, that was the issue I was facing. I have just merged #81 so I assume we can remove this code right? However, in that PR I am adding Apart from that, I made the changes manually and it works great! 🎉 👏 |
…basic-router-and-wp-link-directive
I've removed the manual
Yeah, but first we need to consider what prefetching strategy we want to enable here. |
This PR is branched on top of #82.
This PR adds the remaining functionality: router +
wp-link
directive.It's pretty much a copy/paste of the Query Loop block and Product Query block experiments.