Skip to content

Commit

Permalink
wp-env.json: Pin tt1-blocks dependency to v0.4.3 (#28741)
Browse files Browse the repository at this point in the history
Gutenberg's end-to-end tests were broken for a while after TT1 Blocks removed their `front-page` template (WordPress/theme-experiments#179) -- which our e2e tests relied on. This was fixed on the Gutenberg side in #28638.

Per [this discussion](#28692 (comment)), we might be able to avoid a similar situation in the future by pinning our TT1 Blocks dependency to a given version.

See #28692 for more background.
  • Loading branch information
ockham authored Feb 9, 2021
1 parent a15864f commit 672bd93
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .wp-env.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"plugins": [
"."
],
"themes": [ "WordPress/theme-experiments/tt1-blocks" ],
"themes": [ "WordPress/theme-experiments/tt1-blocks#tt1-blocks@0.4.3" ],
"env": {
"tests": {
"mappings": {
Expand Down
11 changes: 11 additions & 0 deletions packages/env/lib/config/test/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ describe( 'readConfig', () => {
'WordPress/gutenberg',
'WordPress/gutenberg#master',
'WordPress/gutenberg#5.0',
'WordPress/theme-experiments/tt1-blocks#tt1-blocks@0.4.3',
],
} )
)
Expand Down Expand Up @@ -394,6 +395,16 @@ describe( 'readConfig', () => {
path: expect.stringMatching( /^\/.*gutenberg$/ ),
basename: 'gutenberg',
},
{
type: 'git',
url:
'https://github.com/WordPress/theme-experiments.git',
ref: 'tt1-blocks@0.4.3',
path: expect.stringMatching(
/^\/.*theme-experiments\/tt1-blocks$/
),
basename: 'tt1-blocks',
},
],
};
expect( config.env.tests ).toMatchObject( matchObj );
Expand Down

1 comment on commit 672bd93

@nenel1221
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/env/lib/config/test/config.js

Please sign in to comment.