From a37469717e9314195346bcf7475c1f74ee0d239e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9rgio=20Gomes?= <mail@sgomes.com>
Date: Tue, 3 Sep 2024 10:19:53 +0100
Subject: [PATCH] Update PHP tests to match new expected render

---
 .../blocks/render-block-media-text-test.php   | 32 +++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/phpunit/blocks/render-block-media-text-test.php b/phpunit/blocks/render-block-media-text-test.php
index 94c184408c89f..2132f32a619cb 100644
--- a/phpunit/blocks/render-block-media-text-test.php
+++ b/phpunit/blocks/render-block-media-text-test.php
@@ -81,15 +81,15 @@ public function test_render_block_core_media_text_featured_image() {
 		$rendered   = gutenberg_render_block_core_media_text( $attributes, $content );
 		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 
-		// Assert that the rendered block contains the featured image as the background-image url,
-		// and not the image element, when image fill is true.
+		// Assert that the rendered block contains the featured image as an image element
+		// and not as a background-image url, when image fill is true.
 		$attributes = array(
 			'useFeaturedImage' => true,
 			'imageFill'        => true,
 		);
 		$rendered   = gutenberg_render_block_core_media_text( $attributes, $content );
-		$this->assertStringContainsString( 'background-image:url(' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . ')', $rendered );
-		$this->assertStringNotContainsString( '<img', $rendered );
+		$this->assertStringNotContainsString( 'background-image:', $rendered );
+		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 	}
 
 	/**
@@ -107,15 +107,15 @@ public function test_render_block_core_media_text_featured_image_nested() {
 		$rendered   = gutenberg_render_block_core_media_text( $attributes, $content );
 		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 
-		// Assert that the rendered block contains the featured image as the background-image url,
-		// and not the image element, when image fill is true.
+		// Assert that the rendered block contains the featured image as an image element
+		// and not as a background-image url, when image fill is true.
 		$attributes = array(
 			'useFeaturedImage' => true,
 			'imageFill'        => true,
 		);
 		$rendered   = gutenberg_render_block_core_media_text( $attributes, $content );
-		$this->assertStringContainsString( 'background-image:url(' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . ')', $rendered );
-		$this->assertStringNotContainsString( '<img', $rendered );
+		$this->assertStringNotContainsString( 'background-image:', $rendered );
+		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 	}
 
 	/**
@@ -134,16 +134,16 @@ public function test_render_block_core_media_text_featured_image_media_on_right(
 		$rendered   = gutenberg_render_block_core_media_text( $attributes, $content );
 		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 
-		// Assert that the rendered block contains the featured image as the background-image url,
-		// and not the image element, when image fill is true and the media is on the right.
+		// Assert that the rendered block contains the featured image as an image element
+		// and not as a background-image url, when image fill is true and the media is on the right.
 		$attributes = array(
 			'useFeaturedImage' => true,
 			'mediaPosition'    => 'right',
 			'imageFill'        => true,
 		);
 		$rendered   = gutenberg_render_block_core_media_text( $attributes, $content );
-		$this->assertStringContainsString( 'background-image:url(' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . ')', $rendered );
-		$this->assertStringNotContainsString( '<img', $rendered );
+		$this->assertStringNotContainsString( 'background-image:', $rendered );
+		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 	}
 
 	/**
@@ -164,8 +164,8 @@ public function test_render_block_core_media_text_featured_image_media_on_right_
 		$rendered = gutenberg_render_block_core_media_text( $attributes, $content );
 		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 
-		// Assert that the rendered block contains the featured image as the background-image url,
-		// and not the image element, when image fill is true and the media is on the right.
+		// Assert that the rendered block contains the featured image as an image element
+		// and not as a background-image url, when image fill is true and the media is on the right.
 		$attributes = array(
 			'useFeaturedImage' => true,
 			'mediaPosition'    => 'right',
@@ -173,7 +173,7 @@ public function test_render_block_core_media_text_featured_image_media_on_right_
 		);
 
 		$rendered = gutenberg_render_block_core_media_text( $attributes, $content );
-		$this->assertStringContainsString( 'background-image:url(' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . ')', $rendered );
-		$this->assertStringNotContainsString( '<img', $rendered );
+		$this->assertStringNotContainsString( 'background-image:', $rendered );
+		$this->assertStringContainsString( '<img alt="" src="' . wp_get_attachment_image_url( self::$attachment_id, 'full' ) . '"', $rendered );
 	}
 }