Fix RadioGroup to support zero as a Radio value (#27906)

WordPress · Jan 6, 2021 · d94b354 · d94b354
1 parent 35a94fd
commit d94b354
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/components/src/radio-group/index.js b/packages/components/src/radio-group/index.js
@@ -26,8 +26,8 @@ function RadioGroup(
 		...radioState,
 		disabled,
 		// controlled or uncontrolled
-		state: checked || radioState.state,
-		setState: onChange || radioState.setState,
+		state: checked ?? radioState.state,
+		setState: onChange ?? radioState.setState,
 	};
 
 	return (

diff --git a/packages/components/src/radio-group/stories/index.js b/packages/components/src/radio-group/stories/index.js
@@ -47,7 +47,7 @@ export const disabled = () => {
 };
 
 const ControlledRadioGroupWithState = () => {
-	const [ checked, setChecked ] = useState( 'option2' );
+	const [ checked, setChecked ] = useState( 1 );
 
 	/* eslint-disable no-restricted-syntax */
 	return (
@@ -58,9 +58,9 @@ const ControlledRadioGroupWithState = () => {
 			checked={ checked }
 			onChange={ setChecked }
 		>
-			<Radio value="option1">Option 1</Radio>
-			<Radio value="option2">Option 2</Radio>
-			<Radio value="option3">Option 3</Radio>
+			<Radio value={ 0 }>Option 1</Radio>
+			<Radio value={ 1 }>Option 2</Radio>
+			<Radio value={ 2 }>Option 3</Radio>
 		</RadioGroup>
 	);
 	/* eslint-enable no-restricted-syntax */