Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Image exceeds maximum file size" error does not trigger when drag+drop into editor #10191

Closed
eddhurst opened this issue Sep 26, 2018 · 1 comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Milestone

Comments

@eddhurst
Copy link

eddhurst commented Sep 26, 2018

Describe the bug

Dragging + Dropping an image into the editor results in the editor seeing an image preview, with it's opacity transition to indicate that the image is uploading. When doing this with an image that exceeds the file size limit, it doesn't error out, but instead shows the same thing as the above - giving no context to the editor that something has gone wrong.

Doing the same thing within the media uploader results in an immediate error stating that the image size is too large.

To Reproduce
Steps to reproduce the behavior:

  1. Drag + Drop an image into the editor
  2. See error.

1a. Select image block
2a. Drag + Drop image into block
3a. See expected behaviour

Expected behavior
If image exceeds accepted file size limits, it should stop flashing and show an error message.

Screenshots
screen shot 2018-09-26 at 12 39 18

Desktop (please complete the following information):

  • OS: Mac Sierra 10.12.6
  • Browser: Chrome
  • Version: 69.0.3497.100

Additional context

  • Gutenberg 3.9
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2018
@talldan talldan added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block and removed Needs Testing Needs further testing to be confirmed. labels Dec 5, 2018
@talldan
Copy link
Contributor

talldan commented Dec 5, 2018

Confirmed reproduction of the issue and that #10224 solves it. Thanks for the report @eddhurst!

@talldan talldan added the [Feature] Media Anything that impacts the experience of managing media label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants