Deselecting image block when media library message visible should bring back the image.

[paaljoachim]

I added the comment to this PR: #9264 (comment)

I was told this:
"Thanks for the comment @paaljoachim. This PR didn't change that functionality, it's worked the same way in the audio block since before this change, so I think you'd need to create a new issue to cover any changes you think need to be made."

Is your feature request related to a problem? Please describe.
Adding an image (or other content) through the URL then clicking the pencil/edit button and then deselecting the image block the media upload screen is still seen. Deselecting the image block should then remove the media upload message and show the image.

Step by step.

1. Add image or other content where the Upload, Media library and Insert from URL message is seen.

2. See that the content has been added.

3. Click edit/pencil icon. Then Deselect the block.

It should now revert to the content last selected in the block. If no content has been selected then let the upload, media library, Insert form URL message be seen.

[talldan]

Just adding a note that the same UI trait is also apparent in other media blocks (media, video).

[designsimply]

Tested and confirmed using WordPress 4.9.8 and Gutenberg 4.2.0-rc.1 with Firefox 63.0 on macOS 10.13.6 that attempting to edit an image that has been inserted by URL results in the image getting removed and the placeholder reappearing. (47s)

[talldan]

I'm unsure that this is actually a bug. Fixing this could result in a user not being able drag and drop to replace the image (since when the user clicks away to choose a file the placeholder would lose focus and the block would switch back to displaying the image).

Having said that, I think the experience of displaying the placeholder when clicking the edit button is a bit clunky—it'd be cleaner to display the URL Popover (like the user sees when they click Insert From URL initially) when the edit/pencil toolbar icon is clicked.

[designsimply]

the experience of displaying the placeholder when clicking the edit button is a bit clunky—it'd be cleaner to display the URL Popover

Would the popover be pre-filled with the previous URL in that case?

Example use case: I want to grab the URL of an image I've inserted by URL. I click the image then click the pencil icon hoping to copy the URL.

[talldan]

@designsimply - Yep, that's how I'd imagine it working.

[designsimply]

Re-tested and confirmed with 5.2-alpha-44784 but I also noticed the link popover is filled if you click on "Insert from URL" again.

Adding the Good First Issue label to suggest that the "Insert from URL" popover should appear automatically if a URL can be detected when the pencil icon for an image block is clicked.

[youknowriad]

I think the flow have been updated with the thumbnail of the image visible on the placeholder now. I think we can close the issue now?

[paaljoachim]

Yes. I agree.