Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer reliably select left/right aligned blocks #11442

Closed
maddisondesigns opened this issue Nov 3, 2018 · 5 comments
Closed

Can no longer reliably select left/right aligned blocks #11442

maddisondesigns opened this issue Nov 3, 2018 · 5 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels.

Comments

@maddisondesigns
Copy link

maddisondesigns commented Nov 3, 2018

Describe the bug
I raised #10300 because it's impossible to move right aligned blocks.

With WP 5.0 Beta 2 this has gotten even worse, and I can no longer reliably select right (or left) aligned blocks.

When trying to select a simple Image Block that has been right (or left) aligned, it selects the Paragraph block next to it instead and in the sidebar, it seems to think that it's selected 2 blocks and gives me some sort of weird "Coming Soon" message.

screenshot_254

Sometimes the image blocks actually selects, as expected, but the majority of the time it doesn't.

To Reproduce
Steps to reproduce the behaviour:

  1. Add multiple paragrph blocks
  2. Add image block and right align it in the middle of the paragraph blocks
  3. Try and select the image block

Expected behaviour
It shouldn't be this hard to select a block, even if it's right aligned

Desktop (please complete the following information):

  • OS: MacOS Sierra 10.12.6
  • Browser: Firefox Quantum 62.0.2 (64-bit)
  • WP 5.0-beta2-43859
  • TwentyNineteen

Additional context

@maddisondesigns maddisondesigns changed the title Can no longer reliably select right aligned blocks Can no longer reliably select left/right aligned blocks Nov 3, 2018
@maddisondesigns
Copy link
Author

Another side effect to this is that you can no longer edit the text on a Cover Block

@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 5, 2018
@designsimply
Copy link
Member

First, it's worth noting that there is some work in progress at #11357 to refactor the contextual toolbar to work better with floats and there's an open call for testing out for that PR. Since that work is in progress, to test it you would want to use WP 4.9.8 and using the "Clone or download" button for the branch try/float-fixes branch which you can find at https://github.com/WordPress/gutenberg/tree/try/float-fixes

For the issue at hand in current versions, first I tested with WordPress 4.9.8 and Gutenberg 4.2.0 using Firefox 63.0.1 on macOS 10.13.6 and was unable to reproduce.

I also tested with WordPress 5.0-beta3-43876 with similar results. (1m25s)

Closing for now and would like to note that I appreciate the report and if you are still having trouble with this in WP 5.0 beta 3, please reply back and let me know what specific version you're up to and I can try re-testing with you.

@designsimply designsimply added [Block] Image Affects the Image Block General Interface Parts of the UI which don't fall neatly under other labels. and removed Needs Testing Needs further testing to be confirmed. [Block] Image Affects the Image Block labels Nov 7, 2018
@maddisondesigns
Copy link
Author

I've just retested with 5.0-beta3-43876 and the selection is working better now so happy for you to keep this closed.

@dameer
Copy link

dameer commented Dec 17, 2018

That issue is NOT FIXED at all. Left or Right aligned/floated elements are no longer selectable once off the focus. Embedded stuff, pull quotes, etc. This is sooooo frustrating! Awful. Impossible to work with. Literally.

@designsimply
Copy link
Member

@dameer would you mind re-checking this and opening a new issue noting an example set of steps to reproduce and mentioning the latest WP version number you've tested with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

No branches or pull requests

3 participants