Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit Code Editor button is hidden when notices show up #11807

Closed
Rahmon opened this issue Nov 13, 2018 · 2 comments · Fixed by #15594
Closed

Exit Code Editor button is hidden when notices show up #11807

Rahmon opened this issue Nov 13, 2018 · 2 comments · Fixed by #15594
Labels
[Feature] Code Editor Handling the code view of the editing experience [Package] Notices /packages/notices

Comments

@Rahmon
Copy link
Contributor

Rahmon commented Nov 13, 2018

Describe the bug
Exit Code Editor button is hidden when notices show up. This bug occurs only in desktop.

To Reproduce
Steps to reproduce the behavior:

  1. Switch to Code Editor.
  2. Make some change and update.
  3. The notice show up and Exit Code Editor button get hidden.

Expected behavior
Exit Code Editor button always visible while Code Editor mode is enabled.

Screenshots
Desktop:
desktop

Mobile (works as expected):
mobile

Desktop (please complete the following information):

  • OS: Fedora 29
  • Browser Chrome
  • Version 70
@aduth
Copy link
Member

aduth commented May 24, 2019

@youknowriad While I think it's fair to say that #15594 would resolve this as far as the immediate issue of the save confirmation blocking the button, it would still remain an issue for any other notice which occupies this space.

I think it would be good to have a similar treatment to pushing down content in the code editor as @jasmussen had previously implemented for the visual editor in #13614.

@youknowriad
Copy link
Contributor

I think it would be good to have a similar treatment to pushing down content in the code editor as @jasmussen had previously implemented for the visual editor in #13614.

This is already implemented but not for all the notices. I think once the more temporary notices become snackbar notices, this could be considered to be applied to all the remaining notices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Code Editor Handling the code view of the editing experience [Package] Notices /packages/notices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants