-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLInput component needs a custom 'placeholder' attribute #11852
Comments
Placeholder for
Please note that this component was moved to |
the hard coded placeholder provides a challenging user experience for |
Yea, it's weird to have the "or search" option when there's a prop to disable suggestions. I can take over this if an affirmative decision is made. :) |
It does not yet appear to be documented, so this issue should remain open until that is resolved. |
I believe this ticket can be closed now that #36799 has been merged. |
Editor's Update 2019-12-05 (by @aduth): A
placeholder
prop now exists forURLInput
as of #17846, but is not yet documented. The task should now reflect the need for documentation.Describe the bug
Similar to other block components like
RichText
, theURLInput
block needs to have a configurableplaceholder
attribute so custom blocks can set a different value other than the defaultPaste URL or type to search
It currently does not allow for one:
https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/url-input/index.js#L243
Additional context
I also encountered other bugs with
URLInput
that I'll file new issues for.The text was updated successfully, but these errors were encountered: