Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing usage of currentColor in CSS #12328

Closed
webmandesign opened this issue Nov 26, 2018 · 1 comment
Closed

Optimizing usage of currentColor in CSS #12328

webmandesign opened this issue Nov 26, 2018 · 1 comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@webmandesign
Copy link
Contributor

Issue description
currentColor is a default value for various CSS properties. So, there is no need to set it up as border-color in certain cases, for example.

Expected behavior
Not using currentColor value when redundant.

Additional context

  • Gutenberg v4.5.1
@webmandesign
Copy link
Contributor Author

I've removed currentColor from borders recently.

Still, there is a questionable usage of the value in /packages/editor/src/components/inserter-list-item/style.scss file. There are 2 instances of currentColor that could be replaced with inherit in my opinion. Surely, the result would be the same, so this is for reconsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants