Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuItem aria-label just repeats the visible text #12501

Closed
afercia opened this issue Dec 1, 2018 · 1 comment
Closed

MenuItem aria-label just repeats the visible text #12501

afercia opened this issue Dec 1, 2018 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Dec 1, 2018

Noticed while looking at #12309

The MenuItem component has an aria-label attribute that just repeats the visible text of the menu item. For example:

<button type="button" aria-label="Visual Editor" aria-checked="true" role="menuitemradio" class="...">
    Visual Editor
</button>

While it doesn't harm anything, it's redundant. Not sure if there's a specific reason for the aria-label but, unless I'm missing something, maybe it could be simply removed?

@afercia afercia added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Dec 1, 2018
@jorgefilipecosta jorgefilipecosta added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 7, 2018
@timwright12
Copy link
Contributor

I can knock this one out today (via @10up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants