Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space after italics gets deleted when using keyboard shortcut #12529

Closed
killermann opened this issue Dec 2, 2018 · 4 comments · Fixed by #13697
Closed

Space after italics gets deleted when using keyboard shortcut #12529

killermann opened this issue Dec 2, 2018 · 4 comments · Fixed by #13697
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended

Comments

@killermann
Copy link

Describe the Bug
When writing, if you use keyboard shortcut for italics (or bold), then hit space before un-italicizing, the space gets deleted when you un-italicize, and any further typing gets italicized and combined to the previous word.

Steps to reproduce the behavior:

  1. Start typing in a text block
  2. Use keyboard shortcut to switch to italics (cmd+i)
  3. Type italicized word, then a space
  4. Use keyboard shortcut to cancel italics (cmd+i)
  5. Type the next word in sentence.

Expected behavior
Ideally, the editor would put a closing tag on the last character before the space, and allow you to keep typing un-italicized (or un-bolded, etc.).

At the very least, there should be a non-breaking space after the character, then the closing tag.

In either case, you would be able to continue writing un-interrupted. Right now, it requires you to use the mouse to fix, or the right arrow key, which is disruptive to the user's writing flow.

Screenshots
Here's a gif of a short video of the behavior: https://imgur.com/iYvzfBG

I hope it helps, because this was a weird one to describe.

Desktop (please complete the following information):

  • OS: MacOS Mojave 10.14.1
  • Browser: Chrome
  • Version 70.0.3538.110

Additional context

  • Gutenberg 4.6.1
  • Replicated on latest WP, as well as latest 5.0RC
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. labels Dec 2, 2018
@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Dec 5, 2018
@sirjonathan
Copy link

I was having the same issue yesterday and came here today to report it. On testing again today, though, I was not able to reproduce the issue in either the latest versions of Firefox or Chrome. I'm running WordPress 5.0.2 and the Gutenberg plugin is deactivated.

@killermann - I'm curious if you can reproduce the issue again?

@Aurorum
Copy link
Contributor

Aurorum commented Dec 21, 2018

I can confirm that this can still be reproduced with Gutenberg on WordPress.com.

@killermann
Copy link
Author

@sirjonathan just give it a go in Chrome with WP 5.0.2 (not Gutenberg plugin). Identical behavior to my screen recordings above.

So, on my end, still a bug.

One change: I'm not seeing all the   spam in the output, so that's progress.

(sorry for the delay -- holidays and whatnot)

@AtrumGeost
Copy link

Hi folks!

I was able to reproduce this using a Jurassic Ninja site and it also happens when you use the "Bold" button. Here's what I got:

screen capture on 2019-01-28 at 12-56-07

Since the space is deleted, the text will go back to bold. I wasn't able to reproduce this in the Classic Editor.

WordPress 5.0.3 running Twenty Nineteen theme. Chrome Version 71.0.3578.98 (Official Build) (64-bit). macOS Mojave 10.14.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants