Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RichText onSetup docblock #12562

Closed
afercia opened this issue Dec 3, 2018 · 1 comment
Closed

Update RichText onSetup docblock #12562

afercia opened this issue Dec 3, 2018 · 1 comment
Labels
[Type] Developer Documentation Documentation for developers

Comments

@afercia
Copy link
Contributor

afercia commented Dec 3, 2018

The RichText onSetup docblock should be updated after recent changes:

/**
* Handles the onSetup event for the TinyMCE component.
*
* Will setup event handlers for the TinyMCE instance.
* An `onSetup` function in the props will be called if it is present.
*
* @param {tinymce} editor The editor instance as passed by TinyMCE.
*/
onSetup( editor ) {
this.editor = editor;
}

  • it won't use an onSetup function passed via props any longer
  • not sure it's setting up any event handler any longer
  • it's only setting this.editor to the editor instance
@afercia afercia added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels Dec 3, 2018
@ellatrix ellatrix removed the [Type] Bug An existing feature does not function as intended label Dec 5, 2018
@ellatrix
Copy link
Member

ellatrix commented Dec 5, 2018

Yes, this should be updated. This method will also go away once we update list operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

No branches or pull requests

2 participants