Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite against WordPress trunk #12839

Closed
danielbachhuber opened this issue Dec 13, 2018 · 8 comments
Closed

Run test suite against WordPress trunk #12839

danielbachhuber opened this issue Dec 13, 2018 · 8 comments
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@danielbachhuber
Copy link
Member

Following up on #10412, the test suite needs to be running against WordPress trunk after the 5.0 backport is complete.

Related 9c75e47 0c12b15

@danielbachhuber danielbachhuber added [Type] Enhancement A suggestion for improvement. [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Dec 13, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0.2 milestone Dec 13, 2018
@youknowriad
Copy link
Contributor

Not sure how the WordPress docker image is maintained, but if it could provide versions for trunk, 5.0,... we could test against all these versions.

@swissspidy
Copy link
Member

That image is maintained by the Docker core team. See https://github.com/docker-library/wordpress.

One can specify a specific WordPress version when using that image and it tries to download it from https://wordpress.org/wordpress-${WORDPRESS_VERSION}.tar.gz

That works for 5.0 and latest, but not for nightly or trunk. I'm sure we could submit a PR for that though.

@youknowriad
Copy link
Contributor

youknowriad commented Dec 14, 2018

@swissspidy This makes me wonder if we could add a redirect from https://wordpress.org/wordpress-nightly.tar.gz to https://wordpress.org/nightly-builds/wordpress-latest.zip which would make this possible right away without any change in the image?

@swissspidy
Copy link
Member

That could work, yes. Not sure if this something the meta team can do or if it needs to be requested at https://make.wordpress.org/systems/.

@aduth
Copy link
Member

aduth commented Apr 22, 2019

That works for 5.0 and latest, but not for nightly or trunk. I'm sure we could submit a PR for that though.

Is this a fair summarization of the action item here?

  1. Submit upstream enhancement to the Docker image to provide trunk and nightly variants
  2. Update references of WP_VERSION in .travis.yml to use trunk in place of latest

@aduth
Copy link
Member

aduth commented May 8, 2019

Yesterday's release of WordPress 5.2 and subsequent universal Gutenberg build failures (#15502, Trac #47183) should serve to reinforce that tests ought to be run against a prerelease version prior to its final release (even if just once).

It was fortunate that the issues discovered were relatively minor, though they certainly could have been much more severe.

@pento
Copy link
Member

pento commented Sep 2, 2019

With the merge of #17004, tests are now running against trunk.

@aduth
Copy link
Member

aduth commented Nov 26, 2019

Nightly downloads are proving to cause some instability in the Travis builds. I have opened #18773 with an overview of the situation, proposing to revert to running the latest stable version instead. If the pull request goes ahead as proposed, we should consider to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants