Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a number greater than 100 or less than 1 breaks the Latest Comments block #12922

Closed
maddisondesigns opened this issue Dec 16, 2018 · 1 comment
Assignees
Labels
[Block] Latest Comments Affects the Latest Comments Block

Comments

@maddisondesigns
Copy link

Describe the bug
If you manually add a number that's greater than 100 or less than 1 into the Number of Comments field, the block breaks.

screenshot_260

To Reproduce
Steps to reproduce the behavior:

  1. Add Latest Comments block
  2. Enter 101, 0 or -1 into the Number of Comments field
  3. See block break

Expected behavior
The Number of Comments input field should default back to either 100 or 1 when a number greater than or less than either of those numbers are entered.

Desktop (please complete the following information):

  • macOS Sierra
  • Firefox Quantum 63.0.3
  • WP 5.0.1
@Soean Soean added the [Block] Latest Comments Affects the Latest Comments Block label Dec 16, 2018
@swissspidy
Copy link
Member

Noticed the same in #10791 (comment)

It‘s a general bug with the RangeControl component as it doesn‘t enforce min/max when typing a number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Comments Affects the Latest Comments Block
Projects
None yet
Development

No branches or pull requests

4 participants