Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashing background when typing inside an inline text boundaries #12978

Closed
youknowriad opened this issue Dec 18, 2018 · 7 comments · Fixed by #13697
Closed

Flashing background when typing inside an inline text boundaries #12978

youknowriad opened this issue Dec 18, 2018 · 7 comments · Fixed by #13697
Labels
[Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended
Milestone

Comments

@youknowriad
Copy link
Contributor

youknowriad commented Dec 18, 2018

To Reproduce
Steps to reproduce the behavior:

  1. Create a post with the following content
<!-- wp:paragraph -->
<p>some <em>italic</em> text</p>
<!-- /wp:paragraph -->
  1. Put the caret inside the "italic" text
  2. Start typing
  3. Notice that the background of the inline boundaries is flashing

flash

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Dec 18, 2018
@youknowriad youknowriad added this to the WordPress 5.0.3 milestone Dec 18, 2018
@Naerriel
Copy link
Contributor

@youknowriad
Unfortunately, I cannot reproduce this bug. Can you, please, tell me what is the block type you are experiencing the issue with?
Can you include a gif?

@youknowriad
Copy link
Contributor Author

In my testing I'm just using the regular paragraph block and typing in an italic text. Unfortunately, I can't record a screenshot as the flashing won't be noticeable in the recording. It's very quick. (The gray background behind the italic text is flashing)

@ellatrix
Copy link
Member

ellatrix commented Jan 3, 2019

I'm aware since a while of this issue, but didn't think it was a huge deal. The problem is the same as #11322: our rich text state is currently not away of the boundaries, so the attribute is remove, then reapplied by TinyMCE. Fixing #11322 would fix this, so I'm inclined to close this as a duplicate.

@youknowriad
Copy link
Contributor Author

#11322 is a PR. Can we keep this issue to track the corresponding PR?

@ellatrix
Copy link
Member

ellatrix commented Jan 3, 2019

Sure!

@m
Copy link

m commented Jan 23, 2019

Any progress here?

@ellatrix
Copy link
Member

@m Working on it. I'll see if I can make any quick fix to avoid the flickering

@ellatrix ellatrix added [Package] Rich text /packages/rich-text and removed [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants