-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a giphy gutenberg block. #13426
Comments
Worth noting that Jetpack as add a giphy block, but this doesn't use Omebed like others. But it does show the demand for the block. |
It looks like the underlying cause is the oembed auto-discovery for the As you'll see in the attached gif, on the first instance it displays the title text but on the second instance it displays correctly. |
The error happens because the oembed endpoint provided by giphy doesn't return the So
needs to change to
|
#13825 is merged now (thanks @spacedmonkey!) which fixes the rendering issue with giphy in the default embed block. |
@notnownikki Thanks. This doesn't mean that we can't go forward with a giphy block. The block is more for people that don't know or understand auto embedding. Giphy is a part of every messaging app people use. Gifs are part of communication now. I think it should be part of gutenberg. |
Agreed! |
+1 - Gif is also used to make articles interactive. |
I've removed the "WP Core Bug" tag since it looks like the upstream blocker was fixed a while ago. If there's still a desire to add a Giphy block in addition to the core embed block, any developer is free to pick this up, though it doesn't look like there's been much momentum within a couple of years. |
Looks like there's an "official" Giphy plugin as well as another that adds a block, I'd recommend looking to see if those two developers want to work together and get the block into the "official" plugin for this |
Add a giphy block to make embedding gifs easily.
Already added ticket in core for the oembed piece.
The text was updated successfully, but these errors were encountered: