Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the wording of smugmug embeds #13691

Closed
paaljoachim opened this issue Feb 6, 2019 · 7 comments · Fixed by #13715
Closed

Adjust the wording of smugmug embeds #13691

paaljoachim opened this issue Feb 6, 2019 · 7 comments · Fixed by #13715
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 6, 2019

I just tested the Smugmug block embed for 5.0 RC-1 and noticed that the wording could be changed:

"Sorry, this embedded content cannot be previewed in the editor."
Change to:
"Embedded content cannot be previewed in the editor."
Or
"Smugmug embedded content cannot be previewed in the editor."

As the word "sorry" feels out of place.

@jasmussen
@brentswisher

@jasmussen jasmussen added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Feb 6, 2019
@jasmussen
Copy link
Contributor

Great ticket, thank you!

@michelleweber
Copy link

Agree, no need to apologize here! "Smugmug embeds can't be previewed in the editor." works.

(If they can be previewed in the normal preview pane, you might consider adding that detail -- it's always nice to give people a positive next step when they hit an error or something doesn't work as expected.)

@jasmussen jasmussen removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Feb 6, 2019
@jasmussen
Copy link
Contributor

Fast work Michelle! This ticket is ready for a PR!

@paaljoachim
Copy link
Contributor Author

Hey Michelle @michelleweber

"Smugmug embeds can't be previewed in the editor."
to me it feels better to spell it out...
"Smugmug embeds cannot be previewed in the editor."

@michelleweber
Copy link

We often go with contractions because they sound more conversational, but if you feel strongly feel free to spell it out.

@paaljoachim
Copy link
Contributor Author

As a foreigner I do believe I use cannot more then can't. Can't to me is more American then cannot.

@jasmussen
Copy link
Contributor

"Cannot" sounds as formal as "father" is to "dad" to me personally. But you bring up a really interesting point, Paal: should we start to create the outlines of a "voice and tone" guideline for the handbook? It could more or less describe the tone of descriptions and titles, how they can provide guides to translators, how long a description should be, do's and don't examples?

CC: @chrisvanpatten because that enters documentation territory. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants