You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Really noble goal, love it. I have a personal preference for 36px because it's base12, and therefore compatible with the 24px grid we're sort of hoping to roll out. But 38px works too.
A question in Slack asked why there are so many separate styles, and why there are "mixins" for these as well. Here's a little context:
Primarily, years of WordPress styles building up in a not-componentized way, means there is a fair bit of CSS bleed, styles that inherit where they shouldn’t.
The mixins are an attempt to provide unified styles, same as these, so when a change across components like these have to be made, it can be done in one place. For example we are trying to reduce the number of focus styles we have — for situations like panels receiving focus, we have the dotted line. For buttons, we have a border. By including the mixins in an array of different components that use these focus styles, we can change the focus style in one place and it will affect all components that use it.
The best way to remove CSS bleed is to patch WordPress itself so all styles are properly scoped. In absence of that, we have to work within the boundaries of overriding CSS.
Describe the bug
Inputs in Gutenberg seems to use various heights, from 28px to 38px tall.
Expected behavior
All inputs (except for TextareaControl) should be the same height.
Screenshots
Personally, I think all single-line inputs should be standardized to 38px.
The text was updated successfully, but these errors were encountered: