Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveReload should be triggered by CSS changes #15433

Closed
iandunn opened this issue May 4, 2019 · 4 comments
Closed

LiveReload should be triggered by CSS changes #15433

iandunn opened this issue May 4, 2019 · 4 comments
Labels
[Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.

Comments

@iandunn
Copy link
Member

iandunn commented May 4, 2019

Is your feature request related to a problem? Please describe.

LiveReload is a very helpful devex feature, but right now it's only triggered by JS changes, so devs have to manually refresh after making CSS changes.

Describe the solution you'd like

LiveReload should also be triggered by CSS changes.

Currently wp-scripts doesn't support SASS, and there isn't a clear direction on that ticket yet. In the meantime, it'd be nice to add it for any vanilla CSS files. Once SASS is supported, it should be added for those as well.

@iandunn iandunn added [Type] Enhancement A suggestion for improvement. [Package] Scripts /packages/scripts labels May 4, 2019
@gziolo
Copy link
Member

gziolo commented May 16, 2019

It looks like it depends on #14801.

@iandunn
Copy link
Member Author

iandunn commented May 16, 2019

I don't think it does. We could just go ahead and add support for .css, .scss, and .sass files now, and it would work today for vanilla CSS, and automatically start working in the future when that issue is resolved. It'd be less work to do it all at once now, since I'd think we'd want vanilla CSS to be supported anyway.

@gziolo
Copy link
Member

gziolo commented Jul 4, 2020

We want to replace LiveReload with React Fast Refresh that should also fix this issue. See #21008.

@gziolo
Copy link
Member

gziolo commented Jan 9, 2021

I also found out that LiveReload seems to be no longer maintained. It doesn’t support webpack 5 that we plan to migrate to somewhat later this year.

I will close this issue in favor of #21008. I wanted to add also that wp-scripts supports imports for CSS, images and fonts as of this week (to be released soon).

@gziolo gziolo closed this as completed Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants