When I click Edit Image, gutenberg displays an image insert instead

[achmedislamic]

Describe the bug
I have old post that is not using gutenberg. So, I convert that post to Blocks. When I convert to Blocks, select an image and click Edit image, Gutenberg displays image insert instead of editing that image like always.

To reproduce
Steps to reproduce the behavior:

1. Open one of your old post
2. Convert that post to Block
3. Select an image and click Edit Image
4. Gutenberg now wants you to insert image rather than editing the selected image.

Expected behavior
Gutenberg should shows image edit modal.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10 October 2018 Update
• Browser Google Chrome
• Version 74

Additional context

• Using Wordpress 5.2

Sorry for my bad english.

[swissspidy]

That is actually a feature... See #14142.

[achmedislamic]

I still don't get it why this is a feature. I really just want to edit the image like the image size, edit the Alt Text, description, etc. If I want to upload a new image, I just create new image block.

And I just realize the image that I used is an old image that I got from Blogger. I migrate my Blogger.com to Wordpress and the image is still from Blogger.

Sorry for my bad english.

[swissspidy]

Oh, I see.

Alt text and image size can be edited through the block sidebar on the right side:

The caption can be added right below the image:

Although there indeed is no link to edit the attachment as a whole 🤔 That is a bit odd.

[achmedislamic]

Oh, this is my bad ☹

I always use the Edit image modal to edit my image. I rarely used block sidebar.
But still, the "Edit image" button should show Edit image modal or highlight the block sidebar. It doesn't seems right the button says "Edit image" but in reality, user see the image upload block.

[swissspidy]

Agreed.

It's more "Replace image" than "Edit image". I guess that label should be replaced. Plus perhaps the pencil could be brought back somewhere to allow opening the media modal.

[kjellr]

In a recent release of Gutenberg (5.5 I believe), that edit icon was swapped out for a more appropriate "swap" icon:

Image details like size/caption/etc. still live in the sidebar, since that's the usual place for those sorts of controls. Since the edit icon confusion has been addressed already, I'm going to mark this as closed, but feel free to let me know if there's another issue that still needs addressing!

[swissspidy]

@kjellr Correct me if I am wrong, but there still seems to be no way to edit the attachment in the media library. Also "Edit image" is misleading when the button is clearly for replacing the image, not editing it. Shouldn't that be addressed?

[kjellr]

Rephrasing that tooltip is certainly something we can do. I'll reopen this ticket to track that.

For editing the image in the media modal, I feel like most of that functionality should happen within Gutenberg eventually. I know there are tickets related to size + cropping (#13748, #14829) for instance — if there are other specific things, they should probably be funneled into individual issues.

[mapk]

There's a new "Replace media" component being built which should be merged soon. It will solve this issue completely. I'm closing this issue because it's actually a feature, and will be solved further with this other PR. #16200