Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon color overrided #16349

Closed
maximebj opened this issue Jun 28, 2019 · 3 comments
Closed

Icon color overrided #16349

maximebj opened this issue Jun 28, 2019 · 3 comments
Labels
[Feature] Block API API that allows to express the block paradigm. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@maximebj
Copy link
Contributor

Hi everyone

I have this issue:

capture 2019-06-28 à 14 31 27

The result should be:

capture 2019-06-28 à 14 31 34

(and the icon is not centered)

It seems than it comes from this CSS:

.components-button.block-editor-block-switcher__no-switcher-icon:disabled .block-editor-block-icon.has-colors { color: #555d66!important; }

My Icon declaration:

icon: { background: '#874476', foreground: "#fff", src: 'warning' },

Are you aware of this bug? Thanks!

@swissspidy swissspidy added [Feature] Block API API that allows to express the block paradigm. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended labels Jun 28, 2019
@jorgefilipecosta
Copy link
Member

I was able to verify this issue in the last version of WordPress, in the master branch, the problem is not happening now because we have the group transform available for all the blocks if we disable the group block the problem starts happening again. Thank you for reporting this issue @maximebj I think it is an unknown bug.

@maximebj
Copy link
Contributor Author

maximebj commented Jul 2, 2019

Glad I can help (at my level) :)

@jorgefilipecosta
Copy link
Member

It seems the color change is intentional to make the user aware that the icon is in a disabled state. The problem is that the background color is not being changed, which may cause the icon to look wrong or even totally unreadable; PR #16390 fixes this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants