Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link selection consistent #17293

Open
Tropicalista opened this issue Sep 1, 2019 · 5 comments
Open

Make link selection consistent #17293

Tropicalista opened this issue Sep 1, 2019 · 5 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@Tropicalista
Copy link

Tropicalista commented Sep 1, 2019

Is your feature request related to a problem? Please describe.
I think Gutenberg is a great improvement.
But there is inconsistency to how links are managed.

Try to explain:

  • text link
  1. Can I add rel nofollow? No, must edit manually
  2. Can I add a css class? No, must edit html
  • button link
  1. Can I add rel nofollow? Yes in sidebar, manually
  2. Can I add a css class? Yes in sidebar
  • image link
  1. Can I add rel nofollow? Yes, must do manually
  2. Can I add a css class? Yes, must do manually

The button link selection is completely out of sync with the rest of interface.

This is very frustrating, and also more frustrating is to explain more and more to clients how to do things.

Describe the solution you'd like
Provide an univoque interface with link selection. Allow

Describe alternatives you've considered
Going back to old editor

video

@talldan talldan added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Sep 2, 2019
@draganescu draganescu added the Needs Design Feedback Needs general design feedback. label Apr 23, 2020
@draganescu
Copy link
Contributor

Howdy, I wonder if it is intended that all these kinds of links support one way to add rel and custom CSS. If yes, then both should be in the LinkControl component.

(cc @getdave what do you think?)

@paaljoachim
Copy link
Contributor

This could use a look through.
@mkaz @aduth

@getdave
Copy link
Contributor

getdave commented Jun 2, 2020

Howdy, I wonder if it is intended that all these kinds of links support one way to add rel and custom CSS.

As I recall we decided to really simplify the link interface. That said, it feels pretty important that you can add rel=nofollow and friends to a link in all situations. The LinkControl component which underpins this is pretty extensible so it would be simple enough to start adding these tools into the LinkControl "settings" draw.

I think it's more a UX/Design thing. Do we want to add this to ALL instances of links. Ditto CSS control.

Also for links that appear within richtext, how should we manage more "advanced" settings? For example, adding CSS doesn't feel like something that should appear directly within the LinkControl interface. Typically with blocks these advanced settings appear in the sidebar, but within inline links we don't have a sidebar available.

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 2, 2020

Hey Dave. @getdave

EDIT:
I made this issue instead: Link Control: Add more controls.
#23011

@paaljoachim paaljoachim added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Oct 27, 2020
@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Nov 9, 2020
@karmatosed
Copy link
Member

I am going to remove the needs design from this as the other issue on link control seems to have come to a conclusion to take a non-interface approach. This is great and means that it can at least start moving on with that.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants