Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easy way to modify links and add toggle options. #17556

Open
phpbits opened this issue Sep 24, 2019 · 6 comments
Open

Add easy way to modify links and add toggle options. #17556

phpbits opened this issue Sep 24, 2019 · 6 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.

Comments

@phpbits
Copy link
Contributor

phpbits commented Sep 24, 2019

Is your feature request related to a problem? Please describe.
Related to : #16609

Describe the solution you'd like
It would be really great if we can easily extend the link format. Adding "rel" attributes value requires us to create a new format and deregister the core one. There's a need for option to add toggles on the link options as well.

Describe alternatives you've considered
Right now I've created a new link format on EditorsKit. But I don't want this solution of mine to cause any issues in the future if in any case there will be API changes. Thanks!

Screen Capture on 2019-09-16 at 12-42-40

@carlenzoliyuri
Copy link

IMHO

"No follow" label is not really simple for all users. "Paid link" is more simple.

And rel for this is ideal rel="nofollow sponsored" for compatibility to all search engine, now. When sponsored be a W3 standard nofollow is useless.

Only one option is good for me.

@bemyhre
Copy link

bemyhre commented Sep 25, 2019

would be awesome.

@blogtutor
Copy link

Yes, please! There is a desperate need for this. Having this ability will increase the Block Editor adoption significantly.

We have hundreds of clients who have been waiting to switch to the Block Editor, and literally the only thing preventing our clients from using the block editor is the inability to add "nofollow" tags to links. (Most of our clients are not comfortable editing HTML.)

I am thrilled that you've been able to add this to EditorsKit -- but I agree, it would be much better to make feature part of Core, and/or to make it so that a smaller plugin can be added (similar to plugins like "Ultimate Nofollow," which only works on Classic Editor), to add this feature.

@keepact
Copy link

keepact commented Sep 27, 2019

I was able to add this option by writing a lot of code, it didn't have to be this way. I followed the concepts of this PR #16609 but I'm waiting for new ways to extend this format!

@youknowriad youknowriad added [Package] Format library /packages/format-library [Feature] Extensibility The ability to extend blocks or the editing experience labels Oct 3, 2019
@tw2113
Copy link

tw2113 commented Jan 26, 2020

Maybe instead of a basic toggle that is hardcoded to nofollow, and sponsored, perhaps a sidebar text field to provide rel attributes to be applied. For example, there's still the very useful rel="me" option to indicate relation of linked urls.

Thus far at least, i can get to the link markup with the "edit as html" option, but that's nowhere near as intuitive for others who may not think of that. I also have to be careful not to touch the link again because I assume it'd get lost. A dedicated setting somehow would be nice.

@paaljoachim
Copy link
Contributor

I went ahead and added a new issue:
#23011

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

9 participants