Double clicking needed to add menu item

[karmatosed]

The flow right now seems to not need the extra step of setting me out to then click in to add again. Here is what happened:

[mtias]

This happens intermittently for me.

[shaunandrews]

I'm not able to reproduce this, and it seems more like a bug that a "design feedback" issue.

[mapk]

I'm able to reproduce this. However, I have no idea what's going on and am completely confused by this interaction.

[getdave]

I have been able to replicate this and it's consistently one of the worst pieces of the interaction and UX. We'll look into the technical reasons behind this. Thanks for raising @karmatosed!

[draganescu]

I wonder if the quick fix isn't simply not showing the appender when a menu item is being edited?

[draganescu]

My initial idea was to hide the appender when the menu item is in edit mode. However the problem is that it is not immediately clear what to do to get the appender back.

So, I discovered the problem was the fact that when the appender is clicked the menu item UI shrinks because it is deselected and the appender moves away from below the cursor, and the focus event which should insert a new menu item doesn't fire anymore.

I made a PR that sets the appender absolutely positioned, but not sure this is the best approach yet. Any advice welcome.

[apeatling]

I can reproduce it consistently, just select a menu item then try and hit add:

[renatho]

Just for reference, maybe the origin of this issue was what is being fixed here: #29911

This could cause some weird errors like that by recreating the appender component instance.