Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Modes: Navigation in Select Mode doesn't work smoothly with nested blocks #18780

Closed
gziolo opened this issue Nov 27, 2019 · 1 comment
Closed
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Nov 27, 2019

Describe the bug
Upon entering "Navigation" mode from the nested block, you got stuck in the context of the parent block. You can't use arrow up/down keys to navigate to the parent block. In addition, if there is only one child block, then those keys don't work at all and sometimes the focus gets lost. In effect, you can't enter "Edit" mode anymore with the keyboard.

The same issues exist when tabbing after "Navigation" mode gets enabled for the nested block. The behavior is slightly different. Pressing Tab moves the focus to the Publish Panel. Pressing Shift + Tab moves the focus to the block controls which shouldn't show up in this mode.

Expected behavior
Both arrow up/down keys and tabbing works properly and respects both children and parent blocks.

Screenshots
keyboard-modes
keyboard-modes-tab

Desktop (please complete the following information):

  • OS: macOS
  • Browser Safari
  • Version 13

Additional context
Gutenberg 7.0 - the latest master.

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Nov 27, 2019
@gziolo gziolo changed the title Editor Modes: Navigation Mode doesn't work properly for nested blocks Editor Modes: Navigation in Select Mode doesn't work smoothly with nested blocks Feb 26, 2020
@gziolo
Copy link
Member Author

gziolo commented Apr 28, 2020

I tested again, and it seems to work as expected now. Arrow keys navigation is locked down to it's immediate parent, but tabbing allows to go to the pre/next block regardless of the context.

@gziolo gziolo closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant