Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus issue when using select tool on nested blocks #18881

Closed
ZebulanStanphill opened this issue Dec 3, 2019 · 3 comments · Fixed by #18943
Closed

Focus issue when using select tool on nested blocks #18881

ZebulanStanphill opened this issue Dec 3, 2019 · 3 comments · Fixed by #18943
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended

Comments

@ZebulanStanphill
Copy link
Member

Description

If you click repeatedly in just the right spot, you can get some weird behavior while using the select tool. Clicking too quickly causes the block to become invalid, and then if you try to click a block again, the editor crashes.

select-mode-weirdness
image

How to reproduce

  1. Create a Group block.
  2. Create a Columns block inside the Group block.
  3. Use the Select tool to select the Columns block.
  4. Click in the area shown in the GIF; if you click in the right spot, you will select the Group block.
  5. Keep clicking in the same spot. You will alternate between selecting the Columns and the Group block.
  6. Try clicking more quickly; the block will become invalid. If you keep clicking, the editor will crash.

Environment

  • WordPress 5.4-alpha-46810
  • Gutenberg master as of 0303999
  • Using Dissenter browser 0.70 (based on Chromium 78)
@ZebulanStanphill ZebulanStanphill added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended labels Dec 3, 2019
@talldan
Copy link
Contributor

talldan commented Dec 3, 2019

I couldn't reproduce it in Chrome, but maybe I was clicking in slightly the wrong place.

@ZebulanStanphill
Copy link
Member Author

It seems like the issue is a lot easier to reproduce when using a Group block nested in another Group block. (Look at the breadcrumb bar to see which block you currently have selected.)

@ZebulanStanphill
Copy link
Member Author

Actually, nevermind. How easy it is seems to vary for some reason. If you can't seem to find the right spot, try unselecting the block and trying again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants